[GOOD FIRST ISSUE] # 3 - remove dead cmake flag #3

Closed

opened 2026-07-28 18:11:42 +00:00 by c-ludenberg · 0 comments

c-ludenberg commented

2026-07-28 18:11:42 +00:00

(Migrated from github.com)

remove dead cmake flag from calamares pkgbuild

what

the calamares pkgbuild has a cmake flag that does absolutely nothing.

file

packages/calamares/PKGBUILD — line 72

current

-DCMAKE_DISTRIBUTION_NAME="Antergos NeXT"

should be

deleted. remove that entire line.

why

calamares completely ignores -DCMAKE_DISTRIBUTION_NAME. the "for Antergos NeXT" text you see in the about dialog comes from versionedName in the active branding component at runtime (shipped by calamares-branding-antergos-next), not from cmake.

this flag is actively misleading — anyone reading the pkgbuild thinks it controls the branding text but changing it has zero effect. this is documented in the repo's AGENTS.md as a known gotcha.

how to fix

open packages/calamares/PKGBUILD
find the line with CMAKE_DISTRIBUTION_NAME on line 72
delete it
check that the remaining cmake arguments still chain properly with backslashes
commit

time estimate

2 minutes

contributing guide

first time? check CONTRIBUTING.md in the repo root for how to fork, branch, commit, and open a pr:
https://github.com/Antergos-NeXT/antergos-packages/blob/master/CONTRIBUTING.md

## remove dead cmake flag from calamares pkgbuild ### what the calamares pkgbuild has a cmake flag that does absolutely nothing. ### file packages/calamares/PKGBUILD — line 72 ### current -DCMAKE_DISTRIBUTION_NAME="Antergos NeXT" ### should be deleted. remove that entire line. ### why calamares completely ignores -DCMAKE_DISTRIBUTION_NAME. the "for Antergos NeXT" text you see in the about dialog comes from versionedName in the active branding component at runtime (shipped by calamares-branding-antergos-next), not from cmake. this flag is actively misleading — anyone reading the pkgbuild thinks it controls the branding text but changing it has zero effect. this is documented in the repo's AGENTS.md as a known gotcha. ### how to fix 1. open packages/calamares/PKGBUILD 2. find the line with CMAKE_DISTRIBUTION_NAME on line 72 3. delete it 4. check that the remaining cmake arguments still chain properly with backslashes 5. commit ### time estimate 2 minutes ### contributing guide first time? check CONTRIBUTING.md in the repo root for how to fork, branch, commit, and open a pr: https://github.com/Antergos-NeXT/antergos-packages/blob/master/CONTRIBUTING.md

Commenting is not possible because the repository is archived.